D17739: Add a po file for the list of words in GCompris

Karl Ove Hufthammer noreply at phabricator.kde.org
Sun Jan 20 14:39:05 GMT 2019


huftis added a comment.


  Since the filename, e.g. `alarmclock.ogg`, is used as the key in the JSON file, I think it would be cleaner to use it as a ‘msgctxt’ in the PO file. That way, you don’t have to try to parse the comments to extract the keys when regenerating the JSON files. And it makes it possible to have more the one image with the same ‘msgid’ (homographs with different meaning, e.g. a verb and a noun). (I don’t think there’s currently any such strings, but there may be in the future.)

INLINE COMMENTS

> datasetToPo.py:85
> +                      " / " + lesson['name'] + \
> +                      " / " + voice + \
> +                      ": "+ imageLink)

Consider using the ‘msgctxt’ field for storing the JSON keys.

> poToDataset.py:42
> +for entry in poFile:
> +    word = entry.comment.split('\n')[0].split(' ')[-1].replace("%20", " ")
> +    if word in data:

Consider using the ‘msgctxt’ field for storing the JSON keys.

REVISION DETAIL
  https://phabricator.kde.org/D17739

To: jjazeix, #gcompris, #localization, huftis
Cc: pino, huftis, aacid, kde-edu, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190120/9475a80b/attachment-0001.html>


More information about the kde-edu mailing list