D18319: Improve LiveDataDock and import widget

Christoph Roick noreply at phabricator.kde.org
Thu Jan 17 14:03:01 GMT 2019


croick added a comment.


  The dock looks like this:
  F6553299: image.png <https://phabricator.kde.org/F6553299>

INLINE COMMENTS

> LiveDataDock.cpp:1583
>  
> -	if (m_previousMQTTClient != nullptr && m_previousMQTTClient->clientHostName() == name) {
> -		disconnect(m_clients[m_previousMQTTClient->clientHostName()], &QMqttClient::messageReceived, this, &LiveDataDock::mqttMessageReceivedInBackground);
> +	if (m_previousMQTTClient != nullptr && m_previousMQTTClient->clientHostName() == hostname) {
> +		disconnect(m_previousHost->client, &QMqttClient::messageReceived, this, &LiveDataDock::mqttMessageReceivedInBackground);

Actually I'm not so sure, what `m_previousMQTTClient` (formerly `m_clients[m_previousMQTTClient->clientHostName()]`) is supposed to do. Could someone clarify?

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D18319

To: croick, #labplot
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190117/ffb74bd1/attachment.html>


More information about the kde-edu mailing list