D17945: Tutorial screen added for odd even activity

[Aman Kumar Gupta]

amankumargupta added inline comments.

INLINE COMMENTS

> NumbersOddEven.qml:22
>  
> +
>  Planegame {

Extra empty line.

> TutorialBase.qml:27
> +
> +
> +Rectangle {

Extra empty line.

> TutorialBase.qml:29
> +Rectangle {
> +    id:rect1
> +    anchors.fill: parent

Missing space after "id:" and an id should be a meaningful name.

> TutorialBase.qml:37
> +        id: question
> +        anchors{
> +            left: parent.left

Missing space before {

> TutorialBase.qml:45
> +        }
> +        text: qsTr( "Choose the even number")
> +        font.pixelSize: parent.height * 0.15

extra space after (

> TutorialBase.qml:55
> +    GCText {
> +        id:evenNumber
> +        anchors {

space after id:

> TutorialBase.qml:67
> +        width:  0.9 * parent.width
> +        height:  0.8 * parent.height
> +        z: 2

extra 1 space after ':' and above too.

> TutorialBase.qml:71
> +        MouseArea {
> +             anchors.fill: parent
> +            onClicked: rightmessage.visible = true

indentation

> TutorialBase.qml:95
> +            onClicked: wrongmessage.visible = true
> +            }
> +        }

indentation

> TutorialBase.qml:99
> +     GCText {
> +        id: rightmessage
> +        anchors {

the variable name should be in camel case.

> TutorialBase.qml:104
> +            leftMargin: parent.height * 1.0
> +            }
> +        text: qsTr("Great")

indentation

> TutorialBase.qml:113
> +        z: 2
> +       }
> +

indentation

> TutorialBase.qml:116
> +     GCText {
> +        id: wrongmessage
> +        anchors {

camel case

> TutorialBase.qml:121
> +            leftMargin: parent.height * 0.4
> +            }
> +        text: qsTr("No,this is not an even number")

indentation

> TutorialBase.qml:130
> +        z: 2
> +       }
> +    }

Indentation

> tutorial1.qml:1
> +/* GCompris - tutorial1.qml
> + *

QML file names should begin with capital case. Same for ones below.

> tutorial1.qml:33
> +        id: even
> +        text:  qsTr("For example: 12, 38, 52, 68, 102, 118, 168, 188, 502, 532, 700, 798, 842, 892 , 1000.All of these numbers are even numbers as they leave remainder 0 when divisible by 2.")
> +        fontSizeMode: Text.Fit

2 spaces after "text:". Should be 1 space.

> Planegame.qml:81
> +            property alias tutorialSection: tutorialSection
> +
> +        }

Extra empty line

> Planegame.qml:87
> +
> +        property alias tutorialImage:tutorialImage.visible
> +

space after ':'

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17945

To: dekumar, #gcompris_improvements, jjazeix
Cc: amankumargupta, jjazeix, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190112/4349752f/attachment-0001.html>