D17946: Increase draw velocity

[Alexander Semke]

asemke added inline comments.

INLINE COMMENTS

> XYCurve.cpp:931
> +		#endif
> +    if (plot) {
>  

this is not required since we check this already in line 892.

> XYCurve.cpp:965
> +			if ((xColMode == AbstractColumn::Integer || xColMode == AbstractColumn::Numeric)&&
> +				(yColMode == AbstractColumn::Integer || yColMode == AbstractColumn::Numeric)) {
> +				for (int row = 1; row < xColumn->rowCount(); row++) {

this logic is not quite correct since we can have DateTime on the x-axis and Numeric or Integer on the y-axis or the other way around.

> XYCurve.cpp:975
> +
> +							if (abs(prevPoint.x() - xValue) < dxMinLogical && abs(prevPoint.y()-yValue)< dyMinLogical) continue;
> +

wouldn't an 'or' be even better here?

Please put 'continue' to the next line.

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D17946

To: Murmele, asemke
Cc: kde-edu, Murmele, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190104/a5e2d65a/attachment-0001.html>