D17945: Tutorial screen added for odd even activity

[Johnny Jazeix]

jjazeix requested changes to this revision.
jjazeix added a comment.
This revision now requires changes to proceed.


  You also need to handle correctly the cases where you resize the screen (ctrl+F to remove fullscreen) and be sure texts are well displayed and elements don't override with other ones

INLINE COMMENTS

> Planegame.qml:37
> +
> +    Image {
> +        id: tutorialImage

it should be on the pageComponent

> Planegame.qml:61
>  
> +    property bool tutorialImage: false
> +

you should avoir naming it the same as the image just above.
Where is it used?

> planegame.js:44
>  
> +var tutorialInstructions = [
> +            {

these are specific to numbers-odd-even activity, the instructions should be on its folder (you can put them in the qml)

> tutorial1.qml:1
> +/* GCompris - tutorial1.qml
> + *

these files should be in numbers-odd-even/resource/ folder not in planegame.

> tutorial3.qml:115
> +
> +    GCText {
> +        id: rightmessage

the indentation needs to be fixed

> tutorial5.qml:54
> +       GCText {
> +           id:evenno
> +           anchors {

camelCase + you can write evenNumber, it's easier to read to not use abbrevations

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17945

To: dekumar, #gcompris_improvements, jjazeix
Cc: jjazeix, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190104/f10367ea/attachment.html>