D19095: Adding new Variable models for few backends

Alexander Semke noreply at phabricator.kde.org
Mon Feb 25 07:25:48 GMT 2019


asemke added inline comments.

INLINE COMMENTS

> rsession.cpp:153
>  
>          if(expressionQueue().isEmpty())
> +            if (m_needUpdate)

This logic seems to be the (almost) the same for all session classes. Can we move this maybe to Session.cpp? E.g. to Session::statusChanged()? With this we don't need to touch all the session classes now and to add this m_needUpdate variable everywhere.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D19095

To: sirgienko, asemke
Cc: kde-edu, asemke, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190225/e1c8d8a2/attachment.html>


More information about the kde-edu mailing list