D19245: leftright activity layout issues fixed

Johnny Jazeix noreply at phabricator.kde.org
Sun Feb 24 09:38:16 GMT 2019


jjazeix closed this revision.
jjazeix added a comment.


  committed in https://commits.kde.org/gcompris/e185c82d21879412ef448ab838655699fb340937 with some changes

INLINE COMMENTS

> Leftright.qml:73
>              anchors.top: topBorder.bottom
> +            anchors.topMargin: 20
>              fillMode: Image.PreserveAspectFit

hardcoding a value is never good when you have the possibility to use anchors.
Here, you want to have the blackboard below the score, so let's just put the score bottom as blackboard top anchor.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D19245

To: dekumar, #gcompris_improvements, timotheegiet
Cc: jjazeix, timotheegiet, echarruau, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190224/635ec803/attachment.html>


More information about the kde-edu mailing list