D19095: Adding new Variable models for few backends

Nikita Sirgienko noreply at phabricator.kde.org
Sat Feb 23 19:15:27 GMT 2019


sirgienko added inline comments.

INLINE COMMENTS

> asemke wrote in rbackend.cpp:73
> Why do you want to have this as an configurable parameter? Why not to always enable and use the variable model?

For disabling variable model by user.

> asemke wrote in rhighlighter.h:38
> let's move the declaration of these functions to Cantor::DefaultHighlighter and make them abstract. All deriving classes should provide an implementation for them.

In this moment, not all highlighter supports this variable model, so I think it's no need

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D19095

To: sirgienko, asemke
Cc: kde-edu, asemke, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190223/1d97ccba/attachment.html>


More information about the kde-edu mailing list