D19078: Add settings dialog for Cantor backends

Alexander Semke noreply at phabricator.kde.org
Sat Feb 16 16:32:16 GMT 2019


asemke added inline comments.

INLINE COMMENTS

> MainWin.cpp:1995
> +	KConfigDialog *cantorDialog = new KConfigDialog(this,  QLatin1String("Cantor Settings"), emptyConfig);
> +	foreach(Cantor::Backend* backend, Cantor::Backend::availableBackends())
> +	{

Can you please labplot's code style here?

  for (auto* backend : Cantor::Backend::availableBackends())
       if (backend->config()) //It has something to configure, so add it to the dialog
            cantorDialog->addPage(backend->settingsWidget(cantorDialog), backend->config(), backend->name(),  backend->icon());

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D19078

To: sirgienko, asemke
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190216/7187e8a3/attachment.html>


More information about the kde-edu mailing list