D17945: Tutorial screen added for odd even activity

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> Tutorial4.qml:29
> +    isEven: false
> +    question: qsTr("Choose the odd number")
> +    evenNumber: "59"

the question should be handled directly in TutorialBase.
isEven ? qsTr() : qsTr()

> TutorialBase.qml:65
> +                     onClicked: {
> +                         if(isEven) {
> +                              message.text = qsTr("Great")

are you sure you need to display the same text in if and in else?

> TutorialBase.qml:85-86
> +                          onClicked: {
> +                              if(isEven) {
> +                                   message.text = qsTr("No,this is not an even number.")
> +                              }

missing space after ","

> TutorialBase.qml:106
> +            id: evenNumber
> +            text: " "
> +            fontSize: hugeSize

it should not be a space. Either don't have a default value or set "" (which is the same but better not put anything if not needed)

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17945

To: dekumar, #gcompris_improvements, jjazeix
Cc: echarruau, amankumargupta, jjazeix, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190210/3e108c63/attachment.html>