D18764: Show upper & lowercase letters in KLettres

Albert Astals Cid noreply at phabricator.kde.org
Tue Feb 5 18:44:19 GMT 2019

aacid added subscribers: shubham, aacid.
aacid added inline comments.


> shubham wrote in main.cpp:75
> Sorry, but you can not credit yourself unless you are a maintainer, developer or a documenter  who has done significant amount of contribution to the project.

@shubham While what you say is true that it is our custom I would have preferred if you would have been a bit more tactful while conveying the information. Something like

"Thanks for the patch, our current practices say that we only add people with significant contributions to the credits, so if we accept the patch we would do it without your name in the credits"

or something similar. It says the same but i think it's easier to read by the other person.

  R333 KLettres


To: bigpresh, mlaurent
Cc: aacid, shubham, narvaez, apol, kde-edu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190205/db6ec05b/attachment.html>

More information about the kde-edu mailing list