D18230: Added admin mode to question and answer activity

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> Question_and_answer.qml:64
> +            property int noOfQuestions: 9
> +            property var sampleWidth: 750
> +            property bool levelStarted: false

int?

> Question_and_answer.qml:71
> +            property var longestQuestion: ""
> +            property var questionsCount: 0
> +            property var hash: []

int?

> Question_and_answer.qml:73
> +            property var hash: []
> +            property var currentSubActivity
> +        }

int?

> Question_and_answer.qml:87
> +            anchors.centerIn: playArea
> +            text: qsTr("You are in Admin mode but havn't selected any question")
> +            z: 1

you haven't

> Question_and_answer.qml:242
> +            currentActivity: activity
> +            property bool checked: false
> +            content: Component {

unused?

> Question_and_answer.qml:374
> +                displayDialog(dialogActivityConfig)
> +                for(var child in dialogActivityConfig.configItem.grid.contentItem.children) {
> +                    if (typeof dialogActivityConfig.configItem.grid.contentItem.children[child].checked !== 'undefined') {

you can use of temp variable to store the children, it will be easier to read after

> question_and_answer.js:145
> +function setLongestQuestion() {
> +    var long = ""
> +    for(var i = 0; i < items.allQuestions.length; i++) {

longestText is a better name

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D18230

To: AkshayCHD, #gcompris_activities
Cc: jjazeix, echarruau, kde-edu, #gcompris_activities, harrymecwan, ganeshredcobra, nityanandkumar, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190204/402fd0bf/attachment.html>