D18319: Improve LiveDataDock and import widget
Alexander Semke
noreply at phabricator.kde.org
Sat Feb 2 07:27:20 GMT 2019
asemke accepted this revision.
asemke added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> croick wrote in LiveDataDock.cpp:1583
> Actually I'm not so sure, what `m_previousMQTTClient` (formerly `m_clients[m_previousMQTTClient->clientHostName()]`) is supposed to do. Could someone clarify?
I asked Ferencz, who contributed this code. The idea here was disconnect from the slot if we are going to connect to a new and different host. But the check seems to be wrong here. Also, we disallow in MainWin::newLiveDataSourceActionTriggered() having multiple mqtt live sources having the same host, if I see it correctly. Let's adrdess this outside of this patch.
REPOSITORY
R262 LabPlot
BRANCH
livedock
REVISION DETAIL
https://phabricator.kde.org/D18319
To: croick, #labplot, asemke
Cc: sgerlach, asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190202/6d811a83/attachment.html>
More information about the kde-edu
mailing list