D26250: Fix multiple warnings

[Jasem Mutlaq]

mutlaqja added a comment.


  Btw, you don't have to remove your changes completely. You can enclose them in #if statements. For example
  
  #if QT_VERSION >= QT_VERSION_CHECK(5,13,0)
  jobs.swapItemsAt(currentRow, destinationRow);
  #else
  jobs.swap(currentRow, destinationRow);
  #endif
  
  This way we fix the warning on more recent Qt versions and also it is a reminder for us to remove this check once Qt 5.13 becomes the minimum supported version by KStars, so it's a double win. You can do this for all the changes you proposed above.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D26250

To: shubham, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191228/a2bbb6de/attachment.html>