D26250: Fix multiple warnings

Shubham noreply at phabricator.kde.org
Sat Dec 28 08:01:56 GMT 2019


shubham added a comment.


  Should I leave horizontalAdvance() and sizeInBytes() as it is?

INLINE COMMENTS

> mutlaqja wrote in hipsmanager.cpp:390
> Can you check when this was introduced in Qt as well?

Introduced in Qt 5.10

> mutlaqja wrote in skyqpainter.cpp:913
> Same issue about Qt version check. I think by next year (around April/May), we can increase the requirement for KStars Qt version and then get rid of these #if s

Introduced in Qt 5.11

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D26250

To: shubham, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191228/f2204ae9/attachment.html>


More information about the kde-edu mailing list