D26107: Improved activity smallnumbers dataset
Johnny Jazeix
noreply at phabricator.kde.org
Thu Dec 26 14:11:44 GMT 2019
jjazeix added inline comments.
INLINE COMMENTS
> gletters.js:156
> var isUpper = (letter == letter.toLocaleUpperCase());
> - if (isUpper && letters.indexOf(letter.toLocaleLowerCase()) !== -1)
> + if (letter.toLocaleLowerCase() !== letter.toLocaleUpperCase() && sisUpper && letters.indexOf(letter.toLocaleLowerCase()) !== -1)
> items.keyboard.shiftKey = true;
also, why the updates here and below?
REPOSITORY
R2 GCompris
REVISION DETAIL
https://phabricator.kde.org/D26107
To: shubhammishra, #gcompris, echarruau
Cc: kde-edu, jjazeix, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191226/a1223f67/attachment.html>
More information about the kde-edu
mailing list