D25645: New UI to allow the user to modify the stretch being used.

[Hy Murveit]

murveit added a comment.


  Thanks again for testing and checking out the interface.
  
  I have fixed the issue with floating input. Please re-test.
  
  To address some of the other comments:
  
  - Buttons vs CheckBox: I can happily move to buttons. FYI, the reason I did it as I did was this way it is obvious whether stretching is on or off.
  
  With buttons, I'm  not sure whether a highlighted button means on or off. Further, if I change the label to say "Stretch" or "Unstretched", which 
  would you use when it is stretched? It could mean the current state, or it could mean the state you want after the button is pushed. 
  Anyway, let me know what you want specifically and I'll implement that.
  
  - Grainy while using the slider: Yes, I reduce the resolution (see e.g. fitstab.cpp, line 223, view->setSampling(4))
  
  while dragging to speed up the computation. Otherwise it can get laggy. I could make the sampling a function of the 
  image size and # of channels, but perhaps that's fine tuning that should be done in a follow-up submission.
  
  - Auto vs Stretch: I see that can be confusing. They really are two different things, and you should be able to have one
  
  checked without the other. E.g. If you have the auto-stretch setting on, then when you load an image, you should see both
  checked.If you move the sliders, then Auto should go unchecked, as you've manually overridden the automatically generated 
  parameters. If you then uncheck Stretch, then both would be unchecked and no stretching done. If you re-check stretch, 
  then auto should stay unchecked, as it will remember the previous manual setting. Let me know if it doesn't work that way 
  for you.  It is true, though, that if Stretch is unchecked, and you check Auto, both checks will appear, as setting Auto, to me, 
  implies that you want to Stretch. Again, if this is confusing, let me know if you see a better way.
  
  Please let me know if you see other issues or ways to improve.
  Hy

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D25645

To: murveit, mutlaqja, lancaster, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191202/769ee4a4/attachment.html>