D25648: Molecular editor: Enable loading molecules in other formats than cml

Christian Schärf noreply at phabricator.kde.org
Sun Dec 1 11:36:56 GMT 2019


christianschaerf created this revision.
christianschaerf added a reviewer: Kalzium.
christianschaerf added a project: Kalzium.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
christianschaerf requested review of this revision.

REVISION SUMMARY
  This patch implements loading Molecules in the XYZ and PDB formats by instantiating the appropriate subclass of Avogadro::Io::FileFormat
  based on the file ending.
  
  Additionally, some error handling code was added so Kalzium does not crash when loading a molecule fails.
  
  Note that this patch requires C++14 since make_unique is used. Should it, for some reason, not be possible to include C++14-only code into Kalzium,
  this can be worked around by constructing a std::unique_ptr with raw new.

REPOSITORY
  R326 Kalzium

REVISION DETAIL
  https://phabricator.kde.org/D25648

AFFECTED FILES
  compoundviewer/CMakeLists.txt
  compoundviewer/iowrapper.cpp
  compoundviewer/iowrapper.h
  src/tools/moleculeview.cpp

To: christianschaerf, #kalzium
Cc: kde-edu, christianschaerf, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191201/d618446d/attachment.html>


More information about the kde-edu mailing list