D23571: Replace obsolete methods with non-obsolete ones

Jasem Mutlaq noreply at phabricator.kde.org
Thu Aug 29 22:05:53 BST 2019


mutlaqja added inline comments.

INLINE COMMENTS

> fitsviewer.cpp:243
>          action->setText(i18n(filter.toUtf8().constData()));
> -        filterMapper->setMapping(action, filterCounter++);
> -        connect(action, SIGNAL(triggered()), filterMapper, SLOT(map()));
> +        connect(action, &QAction::triggered, this, [this, &filterCounter] { applyFilter(filterCounter++); });
>      }

The change in here results in missing filters in the GUI menu. Not sure why?

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D23571

To: yurchor, #kstars
Cc: mutlaqja, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190829/10b00c31/attachment-0001.html>


More information about the kde-edu mailing list