D23189: Table to fill Precalculated Stats for Two Sample Independent Z-Test

[Stefan Gerlach]

sgerlach added a comment.


  Looks already quite good. Just some minor comments from me.

INLINE COMMENTS

> CorrelationCoefficient.cpp:343
> +void CorrelationCoefficient::performChiSquareIndpendence(bool calculateStats) {
> +	Q_UNUSED(calculateStats);
>  }

please add a TODO comment if the implementation is not finished

> HypothesisTest.cpp:136
> +		}
> +		case TwoSamplePaired:
> +		case OneSample:

are these cases not implemented yet? If you only consider TwoSampleIndependent please use an if statement.

> HypothesisTest.cpp:184
> +
> +			col1Name = "1";
> +			col2Name = "2";

this is set twice, right? If it's constant you can initialize the QStrings with it.

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D23189

To: devanshuagarwal, sgerlach, asemke
Cc: yurchor, kde-edu, #labplot, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190816/6728c7b9/attachment.html>