D23172: Do not crash immediately when deleting SoftBody attached to a stick

[Yuri Chornoivan]

yurchor created this revision.
yurchor added a reviewer: KDE Edu.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
yurchor requested review of this revision.

REVISION SUMMARY
  It seems that the current code fails to delete softBody in sync with recalculating mechanical constraints. This leads to an assertion fail in Eigen. This patch delays constraints recalculation and sometimes saves Step from crashing.
  
  Any help in triagging the crash and improving this patch will be much appreciated.
  
  https://bugs.kde.org/show_bug.cgi?id=408574
  
  BUG: 408574

TEST PLAN
  1. Start Step.
  2. Add soft body.
  3. Add a stick which starts or ends on any of the soft body particles (to trigger the snapping to this particle).
  4. Delete the soft body using "World" dock or by selecting it and pressing the 'Delete' key.
  5. Step does not crash anymore if one of the stick ends is then moved. However, it crashes if you move the stick as a whole.

REPOSITORY
  R341 Step

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23172

AFFECTED FILES
  step/worldmodel.cc

To: yurchor, #kde_edu
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190815/00118e6c/attachment.html>