D23048: Fix visual glitches in dark themes

[Sebastian Gottfried]

gottfried requested changes to this revision.
gottfried added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> InformationTable.qml:28
>      height: childrenRect.height
> +    
> +    SystemPalette {

Please remove all trailing whitespace.

> InformationTable.qml:29
> +    
> +    SystemPalette {
> +        id: activePalette

Please use `KColorScheme` instead of `SystemPalette` for color scheme colors.

Most of KTouch uses the former now. It has some features like complementary colors `SystemPalette` lacks.

> LearningProgressChart.qml:110
>              ]
> -            width: 250
> +            width: 450
>              model: infoModel

This is not related to colors.

> StatPopupDialog.qml:46
> +    
> +    SystemPalette {
> +        id: activePalette

See above.

> ScoreScreen.qml:110
> +    
> +    SystemPalette {
> +        id: activePalette

See above.

> ScoreScreen.qml:342
>                          id: accuracyLegend
> -                        textColor: colorScheme.normalText
> +                        textColor: activePalette.text
>                          Layout.alignment: Qt.AlignVCenter

This change is not necessary. The legend followed to the color scheme before, too.

> ScoreScreen.qml:351
>                          id: charactersPerMinuteLegend
> -                        textColor: colorScheme.normalText
> +                        textColor: activePalette.text
>                          Layout.alignment: Qt.AlignVCenter

This change is not necessary. The legend followed to the color scheme before, too.

> ScoreScreen.qml:378
>                              backgroundColor: colorScheme.normalBackground
> +                            textColor: activePalette.text
>  

Please use `KColorScheme` instead.

REPOSITORY
  R336 KTouch

REVISION DETAIL
  https://phabricator.kde.org/D23048

To: manuelal, gottfried
Cc: kde-edu, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, mglb, crozbo, ndavis, firef, skadinna, aaronhoneycutt, narvaez, apol, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190812/897ed2ce/attachment.html>