D22954: Rolloff roof handling introduced

[Wolfgang Reissenberger]

wreissenberger added inline comments.

INLINE COMMENTS

> mutlaqja wrote in ksutils.cpp:1042
> Why is this here and not with the rest of the modules above?

arg can carry at most 9 arguments. Therefore I had to split it.

> mutlaqja wrote in dome.cpp:101-102
> This function could be simplified to one line:
> 
> return (currentDome && !currentDome->canAbsMove() && !currentDome->canRelMove()))

OK.

> mutlaqja wrote in opslogs.ui:408
> missing tooltip

Yepp, done.

> mutlaqja wrote in observatory.cpp:270
> CLOSING --> Closing...

Good point.

> mutlaqja wrote in observatory.cpp:285
> Ditto

Agreed.

> mutlaqja wrote in observatory.cpp:565
> No need to use i18n here, the i18n should be used on string literals i18n("Foo") and not on variables.
> 
> So this should be setText(titleCounterpart) and the calling function should use the i18n

OK, sounds reasonable.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D22954

To: wreissenberger, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190807/bdb576ae/attachment-0001.html>