D17945: Tutorial screen added for odd even activity

emmanuel charruau noreply at phabricator.kde.org
Thu Apr 18 09:20:20 BST 2019


echarruau added a comment.


  I finally managed to run openssl and could review your diff.
  This is what I was looking for.
  Code is ok for me, I find it generic enough to be reused in other programs.
  One thing thought. The identation of brackets { and } is broken.
  For example in TutorialBase.qml.
  
  GCText {
  
     id: message
     anchors {
         centerIn: parent
         margins: parent.border.width+1
     }
     text: ""
     fontSizeMode: Text.Fit
     ........
        }
    }
          
  
  Closing brackets should be at the level of the first character of the element it belongs too.
  Could you have a look through your code and tidy the indentation?
  Emmanuel

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17945

To: dekumar, #gcompris_improvements, jjazeix
Cc: aacid, echarruau, amankumargupta, jjazeix, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190418/9dc78a61/attachment.html>


More information about the kde-edu mailing list