D18600: Improvements in ascending_order activity

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> ActivityInfo.qml:29
> +    //: Help title
> +    description: qsTr("Arrange the given alphabets in ascending or descending order as instructed")
> +    //intro: "Arrange the alphabets in the correct order by placing an alphabet in it's correct position"

images?

> ActivityInfo.qml:32
> +    //: Help goal
> +    goal: qsTr("Arranging alphabets in ascending or descending order as instructed")
> +    //: Help prerequisite

images?

> ActivityInfo.qml:36
> +    //: Help manual
> +    manual: qsTr("You are provided with few alphabets. Drag and Drop the alphabets in its correct position to reorder the numbers in ascending or descending order as instructed")
> +    section: "reading"

images?

> OrderingNumbers.qml:66
> +            property bool tilesMarked: false
> +            property var mode
> +        }

string?
can you find a better name than "mode"?

> OrderingNumbers.qml:272
> +                dataToSave = {"orderingType": items.orderingType}
> +                Activity.nextLevel()
> +                Activity.previousLevel()

is there a cleaner way than to do a nextLevel followed by a previousLevel?

> OrderingNumbers.qml:278
> +        BarButton {
> +          id: ok
> +          source: "qrc:/gcompris/src/core/resource/bar_ok.svg";

there should be a "enabled: ..." to avoid having the possibility to click quickly multiple time on the button

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D18600

To: AkshayCHD, #gcompris_activities, jjazeix
Cc: jjazeix, echarruau, kde-edu, #gcompris_activities, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, andreask, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190414/5b0873f3/attachment-0001.html>