D20029: Capture counting corrected

Eric Dejouhanet noreply at phabricator.kde.org
Sun Apr 7 18:47:02 BST 2019


TallFurryMan added a comment.


  That's a good idea, but weeell I have two disagreements : first this is integer calculation and you probably need to reorder your operators, and second, if I understand correctly, you are considering the amount of captures to get equiprobable scattering over all sequence jobs.
  I'll nonetheless test this asap.

INLINE COMMENTS

> scheduler.cpp:4601
>  void Scheduler::findNextJob()
>  {
>      Q_ASSERT_X(currentJob->getState() == SchedulerJob::JOB_ERROR ||

I believe that if you arrive here with currentJob equal to nullptr, there are precautions to take earlier than line 4676?

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D20029

To: wreissenberger, mutlaqja, TallFurryMan
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190407/d606b6f7/attachment.html>


More information about the kde-edu mailing list