D18600: Improvements in ascending_order activity

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> ordering_items.js:29
> +function getRandomNumbers(numOfBoxes, upperBound, lowerBound) {
> +    var n = numOfBoxes
> +    while(num.length < n) {

what is the use of this temp variable?

> ordering_items.js:28
> +
> +function getRandomNumbers(numOfBoxes, upperBound, lowerBound) {
> +    var n = numOfBoxes

these functions are the same for the 3 ordering_*.js files, maybe we can refactor them?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D18600

To: AkshayCHD, #gcompris_activities, jjazeix
Cc: jjazeix, echarruau, kde-edu, #gcompris_activities, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, andreask, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190404/f2c7c465/attachment-0001.html>