D15837: Fix for the Dome interface

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  Added flag UniqueConnection to some D-Bus signal connections, and some logs.
  Removed duplicated property 'logText' in mount interface.
  Fixed syntax error in dome XML interface.
  
  The introspection mechanism is using the source XML interface descriptions to generate a MOC object.
  When there is a syntax error in a XML description, the build stops extracting entry points from the description and DOES NOT produce any error.
  This leads to an incomplete D-Bus interface, with missing properties/calls/signals (the ones after the syntax error).
  The problem is that no connect() call has its return code checked nowhere in the code, so probably an encapsulation of this call would be a good idea.
  On the other hand, we could make the build fail in such situation, but I don't know how to manage this yet.

TEST PLAN
  Load Scheduler test vector 'simple_test_no_twilight.esl', ensure a Dome is in the INDI profile.
  Uncheck "Unpark dome", start the Scheduler. Observe as jobs start executing.
  Before the end of the schedule, stop the Scheduler, check "Unpark dome", restart the Scheduler.
  Without the change, Scheduler hangs for 30 seconds waiting for the dome, disconnects INDI/Ekos, restarts, etc, until failing and stopping.
  With the change, Scheduler waits for the dome to unpark and continues the schedule.

REPOSITORY
  R321 KStars

BRANCH
  bugfix__dome_interface_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15837

AFFECTED FILES
  kstars/ekos/mount/mount.h
  kstars/ekos/scheduler/scheduler.cpp
  kstars/org.kde.kstars.Ekos.Dome.xml

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180929/b7363e10/attachment-0001.html>