D15624: Simplify code in the paintEvent

Albert Astals Cid noreply at phabricator.kde.org
Thu Sep 20 18:10:34 BST 2018


aacid added a comment.


  I'm not really sold out that this is simpler, the array introduces a bit of a disconnect between the coordinates and the button color.
  
  Would you do the same but leaving the coords in the drawPixmap line?

INLINE COMMENTS

> blinken.cpp:120
> +
> +   auto getPixmapFor = [this, sz](blinkenGame::color color, const QString& pixmapName) -> QPixmap {
> +        return getPixmap( m_highlighted & color ?

The spacing of all the new lines is wonky, use tabs

REPOSITORY
  R324 Blinken

REVISION DETAIL
  https://phabricator.kde.org/D15624

To: tcanabrava, aacid
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180920/072dd170/attachment.html>


More information about the kde-edu mailing list