D15575: Removes some warnings from the program by replacing deprecated methods

Tomaz Canabrava tcanabrava at kde.org
Tue Sep 18 19:19:12 BST 2018


I can revert the git ignore thing.
I Belive I messed up on squashing his commits as I was called to help him
fixing a bad rebase.

If you want I can do a followup commit fixing those issues.


Em ter, 18 de set de 2018 às 19:42, Albert Astals Cid <
noreply at phabricator.kde.org> escreveu:

> aacid added a comment. View Revision <https://phabricator.kde.org/D15575>
>
> The commit log seems a bit strange, it says "Remove warnings by replacing
> deprecated methods", but i don't see [almost] any method replaced, it's
> mostly 0 -> nullptr and some static_cast to qobject_cast.
>
> Can you explain the reason for the static_cast->qobject_cast change?
>
> *INLINE COMMENTS*
> View Inline <https://phabricator.kde.org/D15575#inline-84092>.gitignore:1
> CMakeLists.txt.user
>
> We don't usually add .gitignore files to repos as far as i remember
>
> *REPOSITORY*
> R332 Kiten
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D15575
>
> *To: *vallim, tcanabrava, KDE Edu
> *Cc: *aacid, kde-edu, narvaez, apol
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180918/fba7ec5b/attachment.html>


More information about the kde-edu mailing list