D15546: Fix Scheduler slewing stage andwq dome interaction.

[Jasem Mutlaq]

mutlaqja added a comment.


  Oh I apologize!! I made the wrong conclusion looking at the diff! I just applied it now so it's clear. There is one minor change with casting, but the issue is that you moved STAGE_RESLEWING back to setMountStatus(...). The problem is we are now waiting for an EVENT from the mount, but most likely there is no new event after ALIGN_COMPLETE. Since by ALIGN_COMPLETE, the mount would be TRACKING. I actually now do not recall why we need RESLEWING stage? I just looked at alignment module and it would only emit ALIGN_COMPLETE once the diff is within acceptable limits. Maybe before, it used to do a last slew to target? Not sure.

INLINE COMMENTS

> scheduler.cpp:6548
>      if (SchedulerJob::JOB_SCHEDULED == currentJob->getState())
> -    {
> -        QDateTime const now = KStarsData::Instance()->lt();
> -        if (now < currentJob->getStartupTime())
> +        if ((QDateTime) KStarsData::Instance()->lt() < currentJob->getStartupTime())
>              return;

Maybe use dynamic_cast here? I get warnings of "old cast"

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D15546

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180916/b9b6c99c/attachment-0001.html>