D15492: Capture module: fixes for decimal numbers in various locales, and fix for CCD selection

Eric Dejouhanet noreply at phabricator.kde.org
Thu Sep 13 22:07:05 BST 2018

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

  Used system locale to display all numbers in Capture module.
  Made sequence file XML serialization always use the C locale for portability.
  Loaded whatever value is available for guide deviation, enabled or not.
  Loaded whatever HFR value is if file, and reset it if invalid.
  Loaded whatever refocus period is in the file, or reset it if invalid.
  Loaded whatever RA value is in file for meridian flip.
  Displayed proper number of decimals in the job table (based on min exposure time).
  Added a warning about HFR-based autofocus serialization.
  Fixes selection of current CCD when a sequence file is loaded.

  Test plan is to be done at least in:
  - a locale that uses "." as decimal point, such as english
  - a locale that uses "," as decimal point, such as french
  The differential is expected to work with variations of decimal points, but will not change how timestamps are displayed.
  Load test vector "decimal_values.esq" from folder "Tests/capture" in the Capture module.
  Check the exposure field box.
  - With or without the change, it will display proper decimal separator, and convert to a double value without issue.
  - Note the thousands separator is not displayed there.
  Check the exposure column in the table.
  - Without the change, it will display as an integer or with "." as decimal separator.
  - With the change, decimal separator relevant to the current locale will be used.
  - Also note the thousands separator properly displaying if the locale requests it.
  Execute the job, check that the messages properly display the locale-related number format.
  View the test vector in a text editor, and observe the bottom left checkbox settings:
  - Check that guiding deviation is equal to the double value seen in the file, 2 digits after decimal separator.
  - Check that autofocus HFR is equal to the double value seen in the file, 3 digits after decimal separator.
  - Check that refocus periodicity is equal to the integer value seen in the file, no decimal separator.
  - Check that RA hours for meridian flip is equal to the double value seen in the file, 2 digits after decimal separator.
  Change the values, checkbox states and jobs in the Capture module (don't do too much at once).
  Save the resulting sequence under another name.
  Check that all the resulting sequence is using C-language numbers (decimal separator ".", no thousand separator).
  Diff against the original test vector, check that only actual changes went in the new sequence file.
  About the bottom left checkbox settings, check that values are always loaded from the file, even if the checkbox is not enabled.
  Without the change, values from a previous sequence could be retained, leading to unpredictable results.
  Depending on the state of option "Save Sequence HFR to File", check that HFR is saved to the sequence and loaded from it, or reset to zero.
  Observe the warning if "Save Sequence HFR to File" is disabled and HFR-based autofocus is enabled.
  Finally, if you have multiple CCD cameras, prepare a sequence file for each, whatever the content.
  Check that each of your sequences is properly selecting the correct CCD, and properly initializes frame information.

  R321 KStars

  improve__support_decimal_locales (branched from master)



To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180913/307aac0c/attachment-0001.html>

More information about the kde-edu mailing list