D15487: Improve command entry's prompt animation
Nikita Sirgienko
noreply at phabricator.kde.org
Thu Sep 13 21:13:15 BST 2018
sirgienko created this revision.
sirgienko added reviewers: asemke, filipesaraiva.
sirgienko added a project: Cantor.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
sirgienko requested review of this revision.
REVISION SUMMARY
Improve realization and logic in command entry's prompt item animations.
- Disable background colour manipulation
- Set colour for `Queued` status similar to another statuses.
- Change animation realization: from `QTimer` to `QPropertyAnimation`: simpler and convenient
Also disable setting queued status for expression, which we run immediatly
This commit also fix problem with QPropertyAnimation warnings (in short: we start animation, and immideatly remove animated object in `qDeleteAll`, of couse before animation finished)
REPOSITORY
R55 Cantor
BRANCH
new-command-entry-animation-logic
REVISION DETAIL
https://phabricator.kde.org/D15487
AFFECTED FILES
src/commandentry.cpp
src/commandentry.h
src/lib/session.cpp
To: sirgienko, asemke, filipesaraiva
Cc: filipesaraiva, kde-edu, asemke, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180913/4afe4bd3/attachment.html>
More information about the kde-edu
mailing list