D15363: Avoid losing completed count when capture was suspended by a guiding deviation.
Eric Dejouhanet
noreply at phabricator.kde.org
Mon Sep 10 09:16:42 BST 2018
TallFurryMan added a comment.
Yes! Adding a flag to resetStatus was my first change. It worked the same, but when I looked at the diff later on for code-review, it was clear I was adding an API change for a specific problem that could be fixed with the current API, so I decided against it.
If we find other locations in the code where it is interesting to reset the status without losing the completed count, then I can reconsider. One other location I found is when manually stopping/restarting a sequence initiated by the scheduler, but that use case is already difficult to handle.
REPOSITORY
R321 KStars
REVISION DETAIL
https://phabricator.kde.org/D15363
To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180910/52cd93e1/attachment.html>
More information about the kde-edu
mailing list