D15388: Do not abort a job that is repeating because it started long ago, that delay is expected.

Eric Dejouhanet noreply at phabricator.kde.org
Sun Sep 9 20:40:21 BST 2018


TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  When a job is repeating, it is expected that its start time would be further in the past than the normal lead time, because it is repeating.
  Therefore the evaluation of such a job when it repeats must not lead to an abort.
  
  Fixes https://bugs.kde.org/show_bug.cgi?id=398415

TEST PLAN
  Use "duplicated_scheduler_jobs_no_twilight", but change the sequence so that the duplicated job repeats after the lead time.
  Without the change, when a job repeat, a message is logged that that job is aborted, and that job is re-evaluated to restart.
  With the change, when a job repeats, no message is logged, and that job repeats without state change.

REPOSITORY
  R321 KStars

BRANCH
  bugfix__repeated_job_aborting (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15388

AFFECTED FILES
  kstars/ekos/scheduler/scheduler.cpp

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180909/b0378dc6/attachment-0001.html>


More information about the kde-edu mailing list