D15339: Fix mount not unparking after scheduler stops

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  Fixed a wrong state in management of unparking error, causing unparking errors to leave the park state busy unparking.
  Reworked parkMount like unParkMount, managing D-Bus errors properly.
  Fixed transitions to un/parked states, so that those states now match the current state of the mount instead of an expected transition in the state machine.
  Added a safeguard against a null pointer dereference for edge cases leading to null job execution.
  Fixed startup state when Scheduler is stopping, causing unparked states to never be checked properly.

TEST PLAN
  A straightforward way to reproduce the main issue that is fixed here is to use "culmination_no_twilight".
  
  Start the Scheduler, observe as:
  
  - Observatory is started, and elements unparked
  - Scheduler selects one of the jobs, eventually processes it, then sleeps waiting for the next
  - Stop the Scheduler
  - Restart the Scheduler
  
  Without the fix, Scheduler repeatedly logs "Mount unparked", unable to request any element to unpark (actually unable to restart the observatory properly).
  With the fix, Scheduler goes through the different steps of the observatory startup, unparking elements properly.
  
  From there, various situation may be tested with parking states in order to desynchronize the parking engine from the mount actual state.
  Notable is that this differential also restores connection to an INDI mount driver that has disconnected.
  This restoration is done as part of the observatory startup, and a loss of connection during capture is still not managed (except by a subsequent failing guide).

REPOSITORY
  R321 KStars

BRANCH
  bugfix__engine_states_on_scheduler_stop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15339

AFFECTED FILES
  kstars/ekos/scheduler/scheduler.cpp

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180907/e093c9a0/attachment.html>