D16324: Disable trace mode in KmPlot before deleting tracing curve from the plot

Albert Astals Cid noreply at phabricator.kde.org
Sun Oct 28 22:16:30 GMT 2018

aacid added a comment.

  I think it would make more sense if the logic of the code was on View itself and not parser, i.e. parser doesn't care about views, but views care about function it's viewing.
  We already have the
    emit functionRemoved( id );
  in that function so doing something like
  connect(XParser::self(), &Parser::functionRemoved, this, &View::functionRemoved)
  and then make the functionRemoved function do something similar to the new code you added.
  At the end "it's the same", but i think it makes more sense from an architectural point of view.
  What do you think?

  R334 KmPlot


To: yurchor, #kde_edu
Cc: aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181028/8627c90e/attachment.html>

More information about the kde-edu mailing list