D16463: QtMath now provides M_PI constant, operations with degrees, and c++ provides round()

Hugo Carneiro noreply at phabricator.kde.org
Sat Oct 27 17:59:01 BST 2018


Shroudmaster created this revision.
Shroudmaster added reviewers: tcanabrava, rizzitello.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
Shroudmaster requested review of this revision.

REVISION SUMMARY
  Since QtMath library has a proper M_PI the define is not necessary anymore. Furthermore, C++'s round() function behaves in similar fashion to the ROUND2INT macro (rounding away 
  from zero). If this style of rounding is not specifically required, I suggest another revision to change it to rint(), which rounds towards even numbers.

REPOSITORY
  R337 KTurtle

BRANCH
  Math

REVISION DETAIL
  https://phabricator.kde.org/D16463

AFFECTED FILES
  src/canvas.cpp
  src/directiondialog.cpp
  src/interpreter/executer.cpp

To: Shroudmaster, tcanabrava, rizzitello
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181027/20da318a/attachment.html>


More information about the kde-edu mailing list