D16444: QtMath now provides a M_PI constant, operations with degrees and qRound()

Hugo Carneiro noreply at phabricator.kde.org
Sat Oct 27 16:42:17 BST 2018

Shroudmaster abandoned this revision.
Shroudmaster added inline comments.


> aacid wrote in directiondialog.cpp:375
> Are you sure about this?
> qRound(-0.5) returns 0 
> ROUND2INT(-0.5) returns -1

This method is only called when the degree is between 0 or 360. From what I've seem,  the round macro is only used for positive numbers, though it seems to me that this macro is more likely an error than an intended deviation from regular math

  R337 KTurtle


To: Shroudmaster, tcanabrava, rizzitello
Cc: aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181027/7305fc39/attachment.html>

More information about the kde-edu mailing list