D16444: QtMath now provides a M_PI constant, operations with degrees and qRound()

Albert Astals Cid noreply at phabricator.kde.org
Fri Oct 26 23:26:00 BST 2018


aacid added inline comments.

INLINE COMMENTS

> directiondialog.cpp:375
>  	skipValueChangedEvent = true;
> -	directionSpin->setValue(ROUND2INT(deg));
> +	directionSpin->setValue(qRound(deg));
>  	updateCommandBox();

Are you sure about this?

qRound(-0.5) returns 0 
ROUND2INT(-0.5) returns -1

REPOSITORY
  R337 KTurtle

REVISION DETAIL
  https://phabricator.kde.org/D16444

To: Shroudmaster, tcanabrava, rizzitello
Cc: aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181026/faa6816a/attachment.html>


More information about the kde-edu mailing list