D16303: Add earth shadow + lunar eclipse finder

[Jasem Mutlaq]

mutlaqja requested changes to this revision.
mutlaqja added a comment.
This revision now requires changes to proceed.


  Beautiful work Valentine! Can you please rebase and fix the small CMake issue?

INLINE COMMENTS

> CMakeLists.txt:8
>  option(BUILD_KSTARS_LITE "Build KStars Lite" OFF)
> -# minimal requirements
> -cmake_minimum_required (VERSION 2.8.12 FATAL_ERROR)
> +# minimal requirementscmake_minimum_required (VERSION 2.8.12 FATAL_ERROR)
>  

Why change this? just a mistake?

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D16303

To: vboettcher, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181018/30ab9316/attachment-0001.html>