D16133: Port KmPlot away from deprecated KStatusBar and kdelibs4support at all

Christoph Feck noreply at phabricator.kde.org
Wed Oct 17 23:49:05 BST 2018


cfeck accepted this revision.
cfeck added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kmplot.cpp:259
>  
> -	statusBar->insertFixedItem( "1234567890123456", 1 );
> -	statusBar->insertFixedItem( "1234567890123456", 2 );
> -	statusBar->insertItem( "", 3, 3 );
> -	statusBar->insertItem( "", 4 );
> -	statusBar->changeItem( "", 1 );
> -	statusBar->changeItem( "", 2 );
> -	statusBar->setItemAlignment( 3, Qt::AlignLeft );
> +	for (int i = 1; i < 5; ++i)
> +	{

Now that you have changed the enum, I would prefer `for (int i = 0; i < SectionCount; ++i)` and add a `SectionCount` last item in the enum.

REPOSITORY
  R334 KmPlot

REVISION DETAIL
  https://phabricator.kde.org/D16133

To: yurchor, #kde_edu, cfeck
Cc: cfeck, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181017/c583d2fa/attachment.html>


More information about the kde-edu mailing list