D15937: Do not alter the state of the Scheduler while evaluating

[Eric Dejouhanet]

TallFurryMan added inline comments.

INLINE COMMENTS

> scheduler.cpp:692
>      evaluateOnlyB->setEnabled(true);
> -    setJobManipulation(true);
> +    setJobManipulation(!Options::sortSchedulerJobs());
>  

Regression: this creates a link between job sorting and delete button being disabled.

> scheduler.cpp:838
>  {
> -    setJobManipulation(index.isValid());
> +    setJobManipulation(!Options::sortSchedulerJobs() && index.isValid());
>  }

Regression: this creates a link between job sorting and delete button being disabled.

> scheduler.cpp:895
>      queueTable->selectRow(destinationRow);
> -    setJobManipulation(true);
> +    setJobManipulation(!Options::sortSchedulerJobs());
>  

Regression: this creates a link between job sorting and delete button being disabled.

> scheduler.cpp:928
>      queueTable->selectRow(destinationRow);
> -    setJobManipulation(true);
> +    setJobManipulation(!Options::sortSchedulerJobs());
>  

Regression: this creates a link between job sorting and delete button being disabled.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D15937

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181012/1e85fe52/attachment.html>