D15518: Editor - Line highlighting color fix

Albert Astals Cid noreply at phabricator.kde.org
Fri Oct 12 21:14:24 BST 2018


aacid added inline comments.

INLINE COMMENTS

> editor.h:41
>  
> -static const QColor LINE_HIGHLIGHT_COLOR(239, 247, 255);
> +static const QColor LINE_HIGHLIGHT_COLOR(239, 247, 255); //fixed white line glitch on dark plasma themes
>  static const QColor WORD_HIGHLIGHT_COLOR(255, 255, 156);

having a comment here is weird, because you haven't actualyl change the line but the comment seems like you have, so you probably want to remove this comment and if needed make sure it is in the commit log?

REPOSITORY
  R337 KTurtle

REVISION DETAIL
  https://phabricator.kde.org/D15518

To: mvalentino, tcanabrava, #kde_edu
Cc: aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181012/64dad713/attachment-0001.html>


More information about the kde-edu mailing list