D16151: Use "Remember Job Progress" in Scheduler and "Always Reset Sequence When Starting" in Capture.

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  Moved "Remember Job Progress" to Scheduler option pane, add "Always Reset Sequence When Starting".
  Displayed completed/total count of captures in sequence table.
  Fixed a few side-effect issues with ignore progress in Capture module.
  
  This differential supports the following use cases:
  
  - Control the progress of scheduler jobs based on capture storage
  - Reset the capture count of a single sequence job
  - Reset the capture count of all sequence jobs
  
  Those use cases are described at https://github.com/TallFurryMan/kstars/wiki (WIP at the time of this differential).
  
  The option "Remember Job Progress" is now a concept limited to the Scheduler.
  Capture module now completely ignores disk storage, except for assigning a number as suffix to the capture file.
  Capture does execute the sequence requested, as it is described, and nothing else.
  The option "Always Reset Sequence When Starting" controls whether all counts should be reset to zero when pressing button "Start", or left as they were.
  Independently, the end-user can manually reset all counts by clicking the "Reset" button, or a single count by editing the relevant job and clicking the "Reset" button.

TEST PLAN
  Open the Ekos options, Capture pane, check that "Always Reset Sequence When Starting" is disabled.
  
  When using the Capture module alone, starting with "Always Reset Sequence When Starting" disabled:
  
  - Set a few capture settings, click "Preview", check that the preview is proper.
  - Add the capture settings as a job, check that a job is created, and that it displays 0/N as count in the sequence table.
  - Click "Preview", check that preview is proper, and that count doesn't change in the sequence table.
  - Click "Start" to run the sequence, check that the sequence executes, and when complete, displays N/N as count.
  - Click "Start" again, check that sequence does not execute again.
  - Click "Reset", acknowledge the pop-up, check that count now displays 0/N, whatever captures are available on disk.
  - Click "Start" to run the sequence, check that the sequence executes, and when complete, displays N/N as count.
  - Click "+" to add a few more sequence jobs from the same or different capture settings, check that new jobs display 0/N, and that the existing one remains complete at N/N.
  - Click "Start" to run the sequence, check that the completed job doesn't execute, that the first new one does, and click "Stop" in the middle of the process, check job switches to aborted.
  - Click "Start" again, check that the first sequence missing captures resumes from where it left, and click "Stop" again in the middle of the process, check job switches to aborted.
  - Choose an aborted job, double-click on one of the sequence table lines to edit the corresponding job, then click "Reset", check that this job's count is reset to 0/N.
  - Click "Start" again, check that the first sequence missing captures resumes properly.
  - Open the Ekos Options, enable "Always Reset Sequence When Starting" and save settings.
  - Click "Start" again, check that all counts are reset to 0/N immediately.
  - Abort, reset, restart as wanted, check that all counts are always reset to 0/N when starting.
  
  When using the Scheduler module, starting with "Always Reset Sequence When Starting" and "Remember Job Progress" disabled. For each test vector:
  
  - Load test vector, remove all captures that are expected, check that Scheduler does execute all captures as planned by the test schedule and its sequences.
  - Check that the count of captures in storage match the expected sequence (considering there were no errors nor aborts during the execution).
  - Enable "Remember Job Progress" in the Ekos options, click "Evaluate Jobs", check that all schedule jobs are marked complete when evaluated.
  - Remove all captures that are expected, click "Evaluate Jobs", check that all schedule jobs are marked incomplete and ready to run.
  - Enable "Always Reset Sequence When Starting" in the Ekos options, execute the sequence and check that the behavior does not change.
  
  Bug: when using the Scheduler, the capture count provided by the Scheduler is visible in the Capture module when the sequence job is executed, not when the Capture is started.

REPOSITORY
  R321 KStars

BRANCH
  improve__move_remember_job_progress_option (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16151

AFFECTED FILES
  kstars/ekos/capture/capture.cpp
  kstars/ekos/capture/sequencejob.cpp
  kstars/ekos/capture/sequencejob.h
  kstars/ekos/opsekos.ui
  kstars/ekos/scheduler/scheduler.cpp
  kstars/kstars.kcfg

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181012/74d144e2/attachment-0001.html>