D16133: Port KmPlot away from deprecated KStatusBar and kdelibs4support at all

Christoph Feck noreply at phabricator.kde.org
Thu Oct 11 18:37:04 BST 2018


cfeck added inline comments.

INLINE COMMENTS

> kmplot.cpp:268
> +		statusBarLabels.append (label);
> +		Q_ASSERT (statusBarLabels.at(i) == label);
> +	}

Did you actually test this assert? QList indexes start with 0, so if I understand it correctly, it would 'crash' with debugging enabled.

REPOSITORY
  R334 KmPlot

REVISION DETAIL
  https://phabricator.kde.org/D16133

To: yurchor, #kde_edu
Cc: cfeck, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181011/5ee75d17/attachment-0001.html>


More information about the kde-edu mailing list