D16039: Fix compilation issues on Windows

Nikita Sirgienko noreply at phabricator.kde.org
Tue Oct 9 17:46:38 BST 2018


sirgienko added inline comments.

INLINE COMMENTS

> pythonbackend.h:27
>  
> -class CANTOR_EXPORT PythonBackend : public Cantor::Backend
> +class CANTOR_PYTHONBACKEND_EXPORT PythonBackend : public Cantor::Backend
>  {

Is this export necesary?
Other backends don't hasen't used `cantor_export.h`, so maybe this backend shouldn't do it too?

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D16039

To: sdepiets, #cantor, pino
Cc: asemke, pino, sirgienko, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181009/9840ea6d/attachment.html>


More information about the kde-edu mailing list