D16061: Fix the compilation of kiten on Windows

[Kevin Funk]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  Feel free to push after fixing the last remark.

INLINE COMMENTS

> CMakeLists.txt:43
> +    message(STATUS "Found mman-win32 include: ${MMAN_INCLUDE_PATH}")
> +    include_directories(${MMAN_INCLUDE_PATH})
> +    find_library(MMAN_LIBRARY NAMES mman)

Would rather do a `target_include_directories(kiten PRIVATE ${MMAN_INCLUDE_PATH})` in e.g. line 28.

This part here should only *detect* MMAN.

REPOSITORY
  R332 Kiten

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16061

To: sdepiets, #kde_edu, kfunk
Cc: kfunk, kde-edu, sdepiets, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181009/ccae76d4/attachment.html>