D16061: Fix the compilation of kiten on Windows

[Kevin Funk]

kfunk added a comment.


  `ecm_mark_nongui_executable(kitengen)` in CMake code has the same effect I think (and is the cleaner version)

INLINE COMMENTS

> CMakeLists.txt:41
> +        message(FATAL_ERROR "On Windows, you need to install mman-win32 headers.")
> +    endif(NOT MMAN_INCLUDE_PATH)
> +    message(STATUS "Found mman-win32 include :")

Here and below: `endif()` is sufficient

> CMakeLists.txt:42
> +    endif(NOT MMAN_INCLUDE_PATH)
> +    message(STATUS "Found mman-win32 include :")
> +    message(STATUS ${MMAN_INCLUDE_PATH})

Just:

  message(STATUS "Found mman-win32 include: ${MMAN_INCLUDE_PATH}")

> CMakeLists.txt:49
> +    endif(NOT MMAN_LIBRARY)
> +    message(STATUS "Found mman-win32 library :")
> +    message(STATUS ${MMAN_LIBRARY})

Dito, just on one line

> CMakeLists.txt:30
> +if(WIN32)
> +	target_link_libraries(kiten
> +		Qt5::Core

No need for repetition

  if(WIN32)
    target_link_libraries(kiten ${MMAN_LIBRARY})
  endif()

... below the platform agnostic `target_link_libraries(...)` works

REPOSITORY
  R332 Kiten

REVISION DETAIL
  https://phabricator.kde.org/D16061

To: sdepiets, #kde_edu
Cc: kfunk, kde-edu, sdepiets, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181009/28cbe40f/attachment.html>