D16039: Fix compilation issues on Windows

Nikita Sirgienko noreply at phabricator.kde.org
Mon Oct 8 16:55:03 BST 2018


sirgienko added a comment.


  Thanks for this work.

INLINE COMMENTS

> CMakeLists.txt:21
>  if(NOT WIN32)
>    target_link_libraries(cantor_maximabackend KF5::Pty KF5::SyntaxHighlighting)
> +else()

I think, you could remove this `if(NOT WIN32)`, becouse we don't use KPtyProcess with maxima.
Also, need to remove preprocessor's statement in `maximasession.h:31`

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D16039

To: sdepiets, #cantor
Cc: sirgienko, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181008/df0c28d8/attachment-0001.html>


More information about the kde-edu mailing list